Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SITES-14355 - CISCO | Teaser core component - Smart crop issues #2537

Merged
merged 2 commits into from
Jul 6, 2023
Merged

SITES-14355 - CISCO | Teaser core component - Smart crop issues #2537

merged 2 commits into from
Jul 6, 2023

Conversation

LSantha
Copy link
Contributor

@LSantha LSantha commented Jul 4, 2023

  • use a selector for fileupload which works for Teaser component too where the fileupload is not visible initially when the edit dialog is opened
Q                       A
Fixed Issues? SITES-14355
Patch: Bug Fix? Yes
Minor: New Feature? No
Major: Breaking Change? No
Tests Added + Pass?
Documentation Provided
Any Dependency Changes?
License Apache License, Version 2.0

@LSantha
SITES-14355 - CISCO | Teaser core component - Smart crop issues
c87b66a 
 * use a selector for fileupload which works for Teaser component too where the fileupload is not visible initially when the edit dialog is opened
@LSantha LSantha requested a review from bpauli July 4, 2023 15:11
@codecov
Copy link

codecov bot commented Jul 4, 2023 •
edited
Loading

Codecov Report

Merging #2537 (d9b0993) into main (70710ad) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2537   +/-   ##
=========================================
  Coverage     87.19%   87.19%           
  Complexity     2614     2614           
=========================================
  Files           229      229           
  Lines          6958     6958           
  Branches       1054     1054           
=========================================
  Hits           6067     6067           
  Misses          358      358           
  Partials        533      533

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vladbailescu vladbailescu requested review from andreibogdan and cbogdan0707 and removed request for andreibogdan July 5, 2023 08:05
@LSantha LSantha merged commit 8e178c7 into main Jul 6, 2023
15 checks passed
@LSantha LSantha deleted the SITES-14355 branch July 6, 2023 10:24
@LSantha LSantha added this to the 2.23.2 milestone Jul 26, 2023
@vladbailescu vladbailescu mentioned this pull request Aug 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbogdan0707 cbogdan0707 cbogdan0707 approved these changes

@bpauli bpauli Awaiting requested review from bpauli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.23.2
Development

Successfully merging this pull request may close these issues.
2 participants
@LSantha @cbogdan0707